Repository navigation
Refuse unparseable and uppercase-scheme model URLs in the JSON Schema device e2e - #1921
Merged
Merged
Conversation
…tert-json-schema e2e (#1861)
This was referenced Nov 11, 2026
leehack
marked this pull request as ready for review
November 11, 2026 09:38
Contributor
|
Chat app preview removed for |
This was referenced Nov 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat-app-litert-json-schemae2e: refuse anhttp(s)://--model-paththatUri.tryParsecannot parse (it failed open; the value was echoed and compiled into a dart-define), and detecthttp(s)case-insensitively soHTTPS://host/mis a URL, not a local path (0.19.x audit follow-ups (index) #1861, Gate native LiteRT-LM JSON Schema per qualified host and accelerator #1909 re-audit).origin/main; making the scheme match case-sensitive again fails theHTTPS://case.Production-readiness scope
tool/testingonly.Completeness checklist
origin/main.PR type guidance
Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .dart analyzedart test -p vm test/unit/tooling/: only the sixwindows_registry_qualification_test.dartcases fail locally (nopwsh)Matrix Evidence
validation-harnessReview Notes
High-risk regression review